[BUG]: Some bugs and space for improvements

12 replies [Last post]
S.D.
User offline. Last seen 5 hours 18 min ago. Offline
Joined: 2013-04-11
Posts: 21

1. Sometimes new turn begins before a hog stops being affected by fire.
2. The game ends immediately after dealing fatal damage to the last enemy hog, so there is no time to escape from the hog explosion.
3. It would be better if graves of different teams had different colors or marking. So if different teams had same grave type they would be still distinguishable.
4. Ping timeout is too small in my opinion. It would be better to allow players to choose when to kick player due to lags themself.
5. Not registered users cannot rejoin games.

KoBeWi
KoBeWi's picture
User offline. Last seen 6 hours 24 min ago. Offline
Joined: 2010-12-25
Posts: 392

Last one isn't a bug I think.

Theme Editor / Code contributions / WIP
"Official" themes:
Crystal | Belly | Dreamland | Sky | Factory | Beehive | Fire |
Slime | Sanctuary
"Unofficial" themes:
Chalk | Bowser | GIRDERZZZ!!! | Mirage | Sudra | Zombie |
Grindea
Contributed themes:
Cyberspace

S.D.
User offline. Last seen 5 hours 18 min ago. Offline
Joined: 2013-04-11
Posts: 21

KoBeWi allegedly wrote:

Last one isn't a bug I think.

I know it was made intentionally. But i think it's a totaly useless restriction.

nemo
nemo's picture
User offline. Last seen 10 hours 16 min ago. Offline
Joined: 2009-01-28
Posts: 1540

First shouldn't happen. It's more likely there was a brief interruption in fire. It's true it sucks if your turn ends immediately. It's fairly rare. One thing that's been brought up is adding a game flag to make fire only do things between turns. I like the excitement and dynamicness of it moving during turn, but if it was an option, people could decide which they prefer.

Second is specific to "Infinite attack" like highlander which was kinda hacked on as you can see from the code, and got really popular. Extra restrictions could be put in there I guess, if they could be formulated properly. Like maybe don't check for win if damaged hogs exist or something.

Third one has come up before. I dunno... I kiiinda like the fun of carelessly not paying attention and resurrecting a similar one. But, yeah, it's obviously inconsistent and Hedgewars isn't big on hidden info so is kind of abusable. Could maybe give them a coloured aura or something when resurrection is selected...

Fifth...
I can think of a couple reasons for the restriction although I don't know what unc0rr's was...

* avoid unregistered users complaining 'cause another unregistered user "stole" their game
* avoid unlimited unregistered users flooding server with game histories

Might simply be that he tied it into the stats stuff which does need it tho. Maybe he'll comment on this.

--
Oh, what the heck. 1PLXzL1CBUD1kdEWqMrwNUfGrGiirV1WpH <= tip a hedgewars dev

S.D.
User offline. Last seen 5 hours 18 min ago. Offline
Joined: 2013-04-11
Posts: 21

Quote:
First shouldn't happen. It's more likely there was a brief interruption in fire. ... It's fairly rare.

Yes, there are probably interruptions, but they often last like several milliseconds. I suggest to put some delay there, maybe about 2-3 seconds at least. And it's actually not rare at all and is quite abusable.
Quote:
Second is specific to "Infinite attack" like highlander...

And The Specialists too... Maybe just don't check for win until the hog explosion, and all other hogs stop moving (with rope, for example)?
Quote:
Fifth...
* avoid unregistered users complaining 'cause another unregistered user "stole" their game
* avoid unlimited unregistered users flooding server with game histories

There is a possibility to stole access to the server completely anyway. And i don't think the game history occupy that much space. And it was even functioning fine before for a long time.

And what about 4th btw?

nemo
nemo's picture
User offline. Last seen 10 hours 16 min ago. Offline
Joined: 2009-01-28
Posts: 1540

Fourth, dunno, didn't care too much either way. But obviously server needs to have *some* ping cutoff to kill stale connections. If current one is too low in your opinion, can discuss w/ unc0rr. BTW all of these should be bugs in https://issues.hedgewars.org

Also..
"There is a possibility to stole access to the server completely anyway."

No idea what you mean by that. Can you elaborate?

--
Oh, what the heck. 1PLXzL1CBUD1kdEWqMrwNUfGrGiirV1WpH <= tip a hedgewars dev

S.D.
User offline. Last seen 5 hours 18 min ago. Offline
Joined: 2013-04-11
Posts: 21

Quote:
Also..
"There is a possibility to stole access to the server completely anyway."

No idea what you mean by that. Can you elaborate?


When not registered user disconnects, another can log in with the same nick. So first one cannot reconnect to the server and rejoin his game.

nemo
nemo's picture
User offline. Last seen 10 hours 16 min ago. Offline
Joined: 2009-01-28
Posts: 1540

Riiight? That's what I meant by that could be why rejoins aren't permitted for unregistered.
I'm not sure how that contradicts my point.
That's to be expected for unregistered users.

--
Oh, what the heck. 1PLXzL1CBUD1kdEWqMrwNUfGrGiirV1WpH <= tip a hedgewars dev

S.D.
User offline. Last seen 5 hours 18 min ago. Offline
Joined: 2013-04-11
Posts: 21

Quote:
I'm not sure how that contradicts my point.

It doesn't contradict you. I just don't understand why rejoining server for unregistered users is fine, but rejoining game should be forbidden.

S.D.
User offline. Last seen 5 hours 18 min ago. Offline
Joined: 2013-04-11
Posts: 21

6. Observers have rights to vote.

Wuzzy
Wuzzy's picture
User offline. Last seen 1 hour 53 min ago. Offline
Joined: 2012-06-20
Posts: 897

Quote:
1. Sometimes new turn begins before a hog stops being affected by fire.

Accepted.
https://issues.hedgewars.org/show_bug.cgi?id=277

Quote:
2. The game ends immediately after dealing fatal damage to the last enemy hog, so there is no time to escape from the hog explosion.

Accepted.
https://issues.hedgewars.org/show_bug.cgi?id=278

Quote:
3. It would be better if graves of different teams had different colors or marking. So if different teams had same grave type they would be still distinguishable.

Given the fact that “grave distinguishability” is only relevant for resurrector and otherwise completely irrelevant, I think your suggestions are too overkill.

Yes, it's a bit annoying to resurrect the wrong enemy. For now let's just say you need a good memory. xD

Joke aside: I have a different idea: Add some kind of (optional?) overlay for graves while you press a key. Hog hame tags, but for graves. Smile

Note that in 0.9.23, all new teams will automatically have a random grave pre-selected, so the chance of 2 teams sharing graves will be lower. The Statue grave (0.9.22 default) is over-used anyway.
I think I might also add a few graves. Feel free to post graves in the Graves thread or Content Contributions.

Quote:
4. Ping timeout is too small in my opinion. It would be better to allow players to choose when to kick player due to lags themself.

No opinion.

Quote:
Fifth...
I can think of a couple reasons for the restriction although I don't know what unc0rr's was...

* avoid unregistered users complaining 'cause another unregistered user "stole" their game
* avoid unlimited unregistered users flooding server with game histories

Might simply be that he tied it into the stats stuff which does need it tho. Maybe he'll comment on this.

This might be fixable. As long the same user hasn't disconnected from the server yet, there is no reason to assume that the same user magically turned into a different user.

In other words, as long the player didn't leave the server, the player can be treated equally.

Only after leaving the server, all “rejoining rights” should be lost.

UltiMaxKom
UltiMaxKom's picture
User offline. Last seen 5 weeks 10 hours ago. Offline
Joined: 2016-06-26
Posts: 310

S.D. allegedly wrote:
4. Ping timeout is too small in my opinion. It would be better to allow players to choose when to kick player due to lags themself.

Agreed...
But I prefer to make an option for a room that set how small the Ping Timeout allowed there
rather than kicking someone's butt (I just never kick anyone, just too rude in my world (lol)).
So, if the host want to change the amount by default, then it is his choice at all. Without kick ppl's butt (well, more effort to do so)

Wuzzy allegedly wrote:

This might be fixable. As long the same user hasn't disconnected from the server yet, there is no reason to assume that the same user magically turned into a different user.

In other words, as long the player didn't leave the server, the player can be treated equally.

Only after leaving the server, all “rejoining rights” should be lost.


And
I mostly rejoin due BSOD (well, I freaking hate it =[ )
BSOD real much... (occur anytime, unpredictable)
Just hoping we can still rejoin the game after having real bad dream which force us to disconnect from the server (with no intentional purposes)
Because well, can't rejoin the game should be a real nightmare to me then. After all, who want to disconnect on purpose while in mid-game?

I love this quote :
[ "I'd rather be an optimist and a fool than a pessimist and right." -Albert Einstein ]

S.D.
User offline. Last seen 5 hours 18 min ago. Offline
Joined: 2013-04-11
Posts: 21

7. You don't receive "Ping timeout" message if you disconnected not in game.

Copyright © 2004-2017 Hedgewars Project. All rights reserved. [ contact ]