Building with bundled physfs?

8 replies [Last post]
topyli
topyli's picture
User offline. Last seen 2 years 17 weeks ago. Offline
Joined: 2013-11-04
Posts: 9

Hi,

I'm trying to build 0.9.25 on RHEL 7. I can't figure out the cmake flag to use the bundled sysfs library (RHEL7 comes with physfs 2.0.3 which is too old.) Another thread here suggests -DPHYSFS_SYSTEM=0, but that doesn't seem to work. Any better suggestions?

The world demands Hedgewars for the Enterprise! Smile

Wuzzy
Wuzzy's picture
User offline. Last seen 25 weeks 22 hours ago. Offline
Joined: 2012-06-20
Posts: 1304

The bundled PhysFS has been removed in 0.9.25. The flag PHYSFS_SYSTEM is gone, too.

Hedgewars now requires PhysFS 3.0.0 to be installed on your system to build. Read the file INSTALL.md in the Hedgewars directory for more information.

Hi, I am a Hedgewars developer. Smile

nemo
nemo's picture
User offline. Last seen 19 weeks 2 days ago. Offline
Joined: 2009-01-28
Posts: 1861

https://hg.hedgewars.org/hedgewars/rev/99b265e0d1d0

--
Oh, what the heck. 1PLXzL1CBUD1kdEWqMrwNUfGrGiirV1WpH <= tip a hedgewars dev

topyli
topyli's picture
User offline. Last seen 2 years 17 weeks ago. Offline
Joined: 2013-11-04
Posts: 9

Thanks for the info. It might be nice to have the website updated to reflect this fact too.

Wuzzy allegedly wrote:

The bundled PhysFS has been removed in 0.9.25. The flag PHYSFS_SYSTEM is gone, too.

Hedgewars now requires PhysFS 3.0.0 to be installed on your system to build. Read the file INSTALL.md in the Hedgewars directory for more information.

topyli
topyli's picture
User offline. Last seen 2 years 17 weeks ago. Offline
Joined: 2013-11-04
Posts: 9

While I'm bothering you and everybody else, I will ask another question. Can I add physfs3 in the hedgewars source myself, or is it better to install physfs3 system-wide? Building it is not a huge problem of couse.

nemo
nemo's picture
User offline. Last seen 19 weeks 2 days ago. Offline
Joined: 2009-01-28
Posts: 1861

You could restore physfs in hedgewars sources and undo the removal from CMake, but it'd be better to install it system-wide.
Only issue ofc is if anything out there depends on physfs2. That's when distros tend to maintain multiple versions of a lib if necessary.

Probably not the case here though.

--
Oh, what the heck. 1PLXzL1CBUD1kdEWqMrwNUfGrGiirV1WpH <= tip a hedgewars dev

topyli
topyli's picture
User offline. Last seen 2 years 17 weeks ago. Offline
Joined: 2013-11-04
Posts: 9

Nothing seems to depend on physfs2, so I was able to backport physfs3 from fedora and we are back in business. Thanks for all your help!

Wuzzy
Wuzzy's picture
User offline. Last seen 25 weeks 22 hours ago. Offline
Joined: 2012-06-20
Posts: 1304

That's good to hear!

IMO it's generally not a good idea to bundle a library.

Hi, I am a Hedgewars developer. Smile

topyli
topyli's picture
User offline. Last seen 2 years 17 weeks ago. Offline
Joined: 2013-11-04
Posts: 9

Wuzzy allegedly wrote:

IMO it's generally not a good idea to bundle a library.

That's the truth, Ruth. Smile

User login

Copyright © 2004-2024 Hedgewars Project. All rights reserved. [ contact ]